"delete" lines which only delete candidate config shouldn't be ignored #532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
filter_delete_statements()
function is intended to removedelete
statements which doesn't delete anything in the running config. If there aren't any matchingset
statements in the running config, thedelete
statement is deleted. However it doesn't take the previous statements from the candidate config into consideration.This change walks through all statements above each
delete
statement of the candidate config and removes them if they match.ISSUE TYPE
COMPONENT NAME
junos_config
ADDITIONAL INFORMATION
Config task:
Output before change:
Output after change: